Re: [PATCH v11 05/25] mm: Add new readahead_control API

[Andrew Morton]

On Tue, 14 Apr 2020 08:02:13 -0700 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
> 
> Filesystems which implement the upcoming ->readahead method will get
> their pages by calling readahead_page() or readahead_page_batch().
> These functions support large pages, even though none of the filesystems
> to be converted do yet.
> 
> +static inline struct page *readahead_page(struct readahead_control *rac)
> +static inline unsigned int __readahead_batch(struct readahead_control *rac,
> +		struct page **array, unsigned int array_sz)

These are large functions.  Was it correct to inline them?

The batching API only appears to be used by fuse?  If so, do we really
need it?  Does it provide some functional need, or is it a performance
thing?  If the latter, how significant is it?

The code adds quite a few (inlined!) VM_BUG_ONs.  Can we plan to remove
them at some stage?  Such as, before Linus shouts at us :)