Re: [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation

From: Steven Rostedt
Date: Tue Apr 14 2020 - 21:47:14 EST


On Wed, 15 Apr 2020 09:40:20 +0800
Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> wrote:

> On 2020/4/14 15:54, Markus Elfring wrote:
> >> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
> >
> > I suggest to improve the change description.
> >
> > * Adjustment:
> > â operation (i. e. â
> Hi Markus,
>
> Which part of description do you want to change or could you provide an
> example for reference?

That part is fine for me.

>
> >
> > * Will the tag âFixesâ become relevant?
>
> Do you mean to add the following "Fixes" tag?
> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
>

Yeah, that fixes tag is appropriate. But I usually add those myself, you
don't need to resend.

-- Steve