Re: [PATCH resend v8] mfd: mt6360: add pmic mt6360 driver

From: Lee Jones
Date: Wed Apr 15 2020 - 03:20:19 EST


On Wed, 15 Apr 2020, gene_chen(éäå) wrote:

> Hi Lee/Matthias,
>
> I try to fix subject and update again, please help to review it, thanks

Few things wrong with this.

- Please don't top post
- Please snip the parts of the message you're not directly replying to
- Please do not send contentless pings

With regards to the latter point; you sent this patch during the
merge-window (please pay attention to the release cycle). Not a great
deal of reviewing happens during this period. If ~2 weeks have passed
(they haven't), you may assume that your patch has been missed and
submit a [RESEND], but whatever happens, do not ping.

FYI, your patch is on the list - you do not need to send a [RESEND].

> -----Original Message-----
> From: Gene Chen [mailto:gene.chen.richtek@xxxxxxxxx]
> Sent: Tuesday, April 07, 2020 11:37 PM
> To: lee.jones@xxxxxxxxxx; matthias.bgg@xxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; gene_chen(éäå) <gene_chen@xxxxxxxxxxx>; Wilma.Wu@xxxxxxxxxxxx; shufan_lee(ææå) <shufan_lee@xxxxxxxxxxx>; cy_huang(éåå) <cy_huang@xxxxxxxxxxx>
> Subject: [PATCH resend v8] mfd: mt6360: add pmic mt6360 driver
>
> Add mfd driver for mt6360 pmic chip include Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck
>
> Signed-off-by: Gene Chen <gene_chen@xxxxxxxxxxx>
> ---
> drivers/mfd/Kconfig | 12 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/mt6360-core.c | 425 +++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++
> 4 files changed, 678 insertions(+)
> create mode 100644 drivers/mfd/mt6360-core.c create mode 100644 include/linux/mfd/mt6360.h

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog