Re: [PATCH v2 0/7] Add support for Allwinner H6 DVFS

[Maxime Ripard]

Hi Clement,

On Mon, Apr 13, 2020 at 03:37:19PM +0200, ClÃment PÃron wrote:
> On Mon, 6 Apr 2020 at 11:07, ClÃment PÃron <peron.clem@xxxxxxxxx> wrote:
> > On Mon, 6 Apr 2020 at 10:10, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
> > >
> > > Hi,
> > >
> > > On Sun, Apr 05, 2020 at 07:35:54PM +0200, ClÃment PÃron wrote:
> > > > Now that required drivers are merged we can contibute on DVFS
> > > > support for Allwinner H6.
> > > >
> > > > This serie is based on Yangtao Li serie[0] and OndÅej Jirman work[1].
> > > >
> > > > Most of the OPP tables are taken from original vendor kernel[2].
> > > > Plus there is a new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz.
> > > >
> > > > I wrote a simple script to randomly set a frequency during
> > > > a random time[3].
> > >
> > > If you ever need to do that ever again, cpufreq-ljt-stress-test (found
> > > here https://github.com/ssvb/cpuburn-arm) has proven to be very
> > > reliable to detect cpufreq related issues. stress-ng might not be
> > > enough since the (at least older) Allwinner SoCs tend to create cache
> > > corruption when undervolted, and that might not be unnoticed by
> > > stress-ng but will be catched by cpufreq-ljt-stress-test.
>
> The test seems good (see result below) :
>
> # cpufreq-ljt-stress-test
> Creating './whitenoise-1920x1080.jpg' ... done
> CPU stress test, which is doing JPEG decoding by libjpeg-turbo
> at different cpufreq operating points.
>
> Testing CPU 0
>  1800 MHz ............................................................ OK
>  1704 MHz ............................................................ OK
>  1608 MHz ............................................................ OK
>  1488 MHz ............................................................ OK
>  1320 MHz ............................................................ OK
>  1080 MHz ............................................................ OK
>   888 MHz ............................................................ OK
>   816 MHz ............................................................ OK
>   720 MHz ............................................................ OK
>   480 MHz ............................................................ OK
>
> Testing CPU 1
>  1800 MHz ............................................................ OK
>  1704 MHz ............................................................ OK
>  1608 MHz ............................................................ OK
>  1488 MHz ............................................................ OK
>  1320 MHz ............................................................ OK
>  1080 MHz ............................................................ OK
>   888 MHz ............................................................ OK
>   816 MHz ............................................................ OK
>   720 MHz ............................................................ OK
>   480 MHz ............................................................ OK
>
> Testing CPU 2
>  1800 MHz ............................................................ OK
>  1704 MHz ............................................................ OK
>  1608 MHz ............................................................ OK
>  1488 MHz ............................................................ OK
>  1320 MHz ............................................................ OK
>  1080 MHz ............................................................ OK
>   888 MHz ............................................................ OK
>   816 MHz ............................................................ OK
>   720 MHz ............................................................ OK
>   480 MHz ............................................................ OK
>
> Testing CPU 3
>  1800 MHz ............................................................ OK
>  1704 MHz ............................................................ OK
>  1608 MHz ............................................................ OK
>  1488 MHz ............................................................ OK
>  1320 MHz ............................................................ OK
>  1080 MHz ............................................................ OK
>   888 MHz ............................................................ OK
>   816 MHz ............................................................ OK
>   720 MHz ............................................................ OK
>   480 MHz ............................................................ OK
>
> Overall result : PASSED

Awesome, thanks for taking the time to do it :)

Maxime

Attachment: signature.asc
Description: PGP signature