Re: [PATCH] KVM: SVM: Fix build error due to missing release_pages() include

From: Paolo Bonzini
Date: Wed Apr 15 2020 - 10:54:08 EST


On 11/04/20 18:09, Borislav Petkov wrote:
> From: Borislav Petkov <bp@xxxxxxx>
>
> Fix:
>
> arch/x86/kvm/svm/sev.c: In function âsev_pin_memoryâ:
> arch/x86/kvm/svm/sev.c:360:3: error: implicit declaration of function ârelease_pagesâ;\
> did you mean âreclaim_pagesâ? [-Werror=implicit-function-declaration]
> 360 | release_pages(pages, npinned);
> | ^~~~~~~~~~~~~
> | reclaim_pages
>
> because svm.c includes pagemap.h but the carved out sev.c needs it too.
> Triggered by a randconfig build.
>
> Fixes: eaf78265a4ab ("KVM: SVM: Move SEV code to separate file")
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> ---
> arch/x86/kvm/svm/sev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 0e3fc311d7da..0208ab2179d5 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -12,6 +12,7 @@
> #include <linux/kernel.h>
> #include <linux/highmem.h>
> #include <linux/psp-sev.h>
> +#include <linux/pagemap.h>
> #include <linux/swap.h>
>
> #include "x86.h"
>

Queued, thanks.

Paolo