RE: [PATCH] ACPICA: make acpi_protocol_lengths static

From: Kaneda, Erik
Date: Wed Apr 15 2020 - 12:09:50 EST




> -----Original Message-----
> From: Jason Yan <yanaijie@xxxxxxxxxx>
> Sent: Wednesday, April 15, 2020 1:50 AM
> To: Moore, Robert <robert.moore@xxxxxxxxx>; Kaneda, Erik
> <erik.kaneda@xxxxxxxxx>; Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>;
> lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Jason Yan <yanaijie@xxxxxxxxxx>; Hulk Robot <hulkci@xxxxxxxxxx>
> Subject: [PATCH] ACPICA: make acpi_protocol_lengths static
>
> Fix the following sparse warning:
>
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol 'acpi_protocol_lengths'
> was not declared. Should it be static?

This has already been reported and I've made the appropriate fix in the ACPICA code base already. it should be available in the next ACPICA release

Thanks,
Erik
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> ---
> drivers/acpi/acpica/exfield.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c index
> e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> */
> #define ACPI_INVALID_PROTOCOL_ID 0x80
> #define ACPI_MAX_PROTOCOL_ID 0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
> ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
> ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
> 0x00, /* 2 - ATTRIB_QUICK */
> --
> 2.21.1