Re: [PATCH v4 8/9] ASoC: rt5645: Switch DMI table match to a test of variable

[Mark Brown]

On Wed, Apr 15, 2020 at 05:55:23PM +0300, Andy Shevchenko wrote:
> Since we have a common x86 quirk that provides an exported variable,
> use it instead of local DMI table match.
> 
> Note, arch/x86/kernel/quirks.c::early_platform_detect_quirk() prints
> the detected platform.

> @@ -3674,13 +3675,6 @@ static const struct dmi_system_id dmi_platform_data[] = {
>  		},
>  		.driver_data = (void *)&intel_braswell_platform_data,
>  	},
> -	{
> -		.ident = "Microsoft Surface 3",
> -		.matches = {
> -			DMI_MATCH(DMI_PRODUCT_NAME, "Surface 3"),
> -		},
> -		.driver_data = (void *)&intel_braswell_platform_data,
> -	},
>  	{

Are we going to convert all the other platforms to using a variable too?

Attachment: signature.asc
Description: PGP signature