Re: [PATCH] i2c: drivers: Omit superfluous error message inefm32_i2c_probe()

[Tang Bin]

Hi Uwe:

On 2020/4/15 22:22, Uwe Kleine-KÃnig wrote:
> Hello,
>
> On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote:
> > In the function efm32_i2c_probe(),when get irq failed,the function
> > platform_get_irq() logs an error message,so remove redundant message
> > here.
> adding a space after each comma seems usual style.
Got it, I will notice. Whether should I submit v2 for this problems? Thanks.
> > Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Shengju Zhang <zhangshengju@xxxxxxxxxxxxxxxxxxxx>
> Usually the Sign-off of the sender comes last. How is Shengju Zhang
> involved with this patch?
Got it, I will notice next time. Thanks.
> > diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
> > index a8c6323e7..4de31fae7 100644
> > --- a/drivers/i2c/busses/i2c-efm32.c
> > +++ b/drivers/i2c/busses/i2c-efm32.c
> > @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev)
> >   
> >   	ret = platform_get_irq(pdev, 0);
> >   	if (ret <= 0) {
> > -		dev_err(&pdev->dev, "failed to get irq (%d)\n", ret);
> The change looks fine.

Thanks,

Tang Bin

>