Re: [PATCH] x86/kvm: make steal_time static

[Jason Yan]

å 2020/4/15 22:42, Paolo Bonzini åé:
> On 15/04/20 10:49, Jason Yan wrote:
> > Fix the following sparse warning:
> >
> > arch/x86/kernel/kvm.c:58:1: warning: symbol '__pcpu_scope_steal_time'
> > was not declared. Should it be static?
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > ---
> >   arch/x86/kernel/kvm.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> > index 6efe0410fb72..f75010cde5d5 100644
> > --- a/arch/x86/kernel/kvm.c
> > +++ b/arch/x86/kernel/kvm.c
> > @@ -55,7 +55,7 @@ static int __init parse_no_stealacc(char *arg)
> >   early_param("no-steal-acc", parse_no_stealacc);
> >   
> >   static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);
> > -DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
> > +static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
> >   static int has_steal_clock = 0;
> >   
> >   /*
>
> Queued, thanks.

Sorry that I found 14e581c381b9 ("x86/kvm: Make steal_time visible")
said that it is used by assembler code but I didn't find where.
Please drop this patch if it's true.

Sorry to make this trouble again.

Thanks,

Jason

> Paolo
>
>
> .