Re: crypto: api - Fix use-after-free and race in crypto_spawn_alg

From: Herbert Xu
Date: Wed Apr 15 2020 - 22:42:44 EST


On Wed, Apr 15, 2020 at 07:30:01PM -0700, Eric Biggers wrote:
>
> I'm not sure what you mean here. crypto_alg_get() is:
>
> static inline struct crypto_alg *crypto_alg_get(struct crypto_alg *alg)
> {
> refcount_inc(&alg->cra_refcnt);
> return alg;
> }
>
> So given:
>
> target = crypto_alg_get(alg);
>
> Both alg and target have to be non-NULL.

Yes I know that we know that it can't be NULL, but gcc 8.3 doesn't.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt