Re: [PATCH 2/2] irqchip/gic-v4.1: Update effective affinity of virtual SGIs

[Zenghui Yu]

On 2020/4/14 17:50, Marc Zyngier wrote:
> Although the vSGIs are not directly visible to the host, they still
> get moved around by the CPU hotplug, for example. This results in
> the kernel moaning on the console, such as:
>
>    genirq: irq_chip GICv4.1-sgi did not update eff. affinity mask of irq 38
>
> Updating the effective affinity on set_affinity() fixes it.
>
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>

Reviewed-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>


Thanks.

> ---
>   drivers/irqchip/irq-gic-v3-its.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index e24a145f17f6..84366cc1c14f 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -4054,6 +4054,7 @@ static int its_sgi_set_affinity(struct irq_data *d,
>   	 * not on the host (since they can only be targetting a vPE).
>   	 * Tell the kernel we've done whatever it asked for.
>   	 */
> +	irq_data_update_effective_affinity(d, mask_val);
>   	return IRQ_SET_MASK_OK;
>   }
>