Re: [PATCH] iommu/qcom:fix local_base status check

[Tang Bin]

Hi Bjorn:

On 2020/4/2 14:45, Bjorn Andersson wrote:
> On Wed 01 Apr 23:33 PDT 2020, Tang Bin wrote:
>
> > Release resources when exiting on error.
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Thanks for your positive feedback.

I don't know whether the commit message affect this patch's result. If 
so, I think the commit message need more clarification. As follwos:

ÂÂÂÂÂÂÂ The function qcom_iommu_device_probe() does not perform 
sufficient error checking after executing devm_ioremap_resource(), which 
can result in crashes if a critical error path is encountered.

Fixes: 0ae349a0("iommu/qcom: Add qcom_iommu")


I'm waiting for your reply actively.

Thanks,

Tang Bin


> > Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/iommu/qcom_iommu.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> > index 4328da0b0..c08aa9651 100644
> > --- a/drivers/iommu/qcom_iommu.c
> > +++ b/drivers/iommu/qcom_iommu.c
> > @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> >   	qcom_iommu->dev = dev;
> >   
> >   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	if (res)
> > +	if (res) {
> >   		qcom_iommu->local_base = devm_ioremap_resource(dev, res);
> > +		if (IS_ERR(qcom_iommu->local_base))
> > +			return PTR_ERR(qcom_iommu->local_base);
> > +	}
> >   
> >   	qcom_iommu->iface_clk = devm_clk_get(dev, "iface");
> >   	if (IS_ERR(qcom_iommu->iface_clk)) {
> > --
> > 2.20.1.windows.1