Re: [PATCH RFC v1 2/4] dt-bindings: power: meson-ee-pwrc: add support for the Meson GX SoCs

[Neil Armstrong]

Hi Martin,

On 15/04/2020 20:31, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Wed, Apr 15, 2020 at 10:51 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> [...]
>>> +            - const: dvin


Yes I rechecked, and it's part of the VPU.

> before I resend, can you please double-check this reset line?
> it's the only difference compared to G12A so I thought it would make
> sense to check if this is really related to the VPU when we're
> switching from one binding to the other anyways (as now is the time to
> sort out pending issues - in case there is an issue here)
> 
>>> +#define PWRC_GXBB_VPU_ID             0
>>> +#define PWRC_GXBB_ETH_ID             1
>>
>> Should be PWRC_GXBB_ETHERNET_MEM_ID like meson8 bindings.
> I can do that, thank you for looking into this!

Neil

> 
> 
> Martin
>