Re: [PATCH] mfd:asic3:Delete redundant variable definition

[Tang Bin]

Hi, Lee:

On 2020/4/16 15:08, Lee Jones wrote:
> On Fri, 03 Apr 2020, Tang Bin wrote:
>
> > In this function, 'ret' is always assigned, even if 'pdata->leds'
> > don't carry out,it has already been assigned a value in the above
> > code, including '0',so it's redundant.
> Which line initialises/assigns 'ret' before this one?

ÂÂÂ I think it maybe my fault before, because I treat get resource and 
irq succeed. But now I have two questions to ask you:

ÂÂÂ Q1: About asic3_mfd_probe()?

ÂÂÂÂÂÂÂÂÂ In the function asic3_mfd_probe(), if get resource or irq 
failed, the value returned just detected and dev_dbg() error message, 
but there were no error return. What I think the modify should be as 
follows:

ÂÂÂ mem_sdio = platform_get_resource(pdev, IORESOURCE_MEM, 1);
ÂÂÂ if (!mem_sdio) {
ÂÂÂ ÂÂÂ dev_dbg(asic->dev, "no SDIO MEM resource\n");
ÂÂÂ ÂÂÂ ret = -EINVAL;
ÂÂÂ ÂÂÂ goto out;
ÂÂÂ }

ÂÂÂ irq = platform_get_irq(pdev, 1);
ÂÂÂ if (irq < 0) {
ÂÂÂ ÂÂÂ dev_dbg(asic->dev, "no SDIO IRQ resource\n");
ÂÂÂ ÂÂÂ ret = irq;
ÂÂÂ ÂÂÂ goto out;
ÂÂÂ }

ÂÂÂ If the function do like this, the 'ret = 0' in line 993 maybe 
redundant.


ÂÂ Q2: About asic3_probe()?

ÂÂÂÂÂÂÂÂÂ In the line 995, if the function asic3_irq_probe() failed, it 
will print error message by the internally called function 
platform_get_irq(), so the dev_err() in the line 997 is redundant, 
should be delete.


ÂÂÂ I'll wait actively, and submit the corresponding patch according to 
your reply.


Thanks,

Tang Bin