Re: [PATCH] iommu/qcom:fix local_base status check

[Tang Bin]

On 2020/4/16 18:05, Robin Murphy wrote:
> On 2020-04-02 7:33 am, Tang Bin wrote:
> > Release resources when exiting on error.
> >
> > Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > Â drivers/iommu/qcom_iommu.c | 5 ++++-
> > Â 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> > index 4328da0b0..c08aa9651 100644
> > --- a/drivers/iommu/qcom_iommu.c
> > +++ b/drivers/iommu/qcom_iommu.c
> > @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct 
> > platform_device *pdev)
> > ÂÂÂÂÂ qcom_iommu->dev = dev;
> > Â ÂÂÂÂÂ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -ÂÂÂ if (res)
> > +ÂÂÂ if (res) {
> > ÂÂÂÂÂÂÂÂÂ qcom_iommu->local_base = devm_ioremap_resource(dev, res);
> > +ÂÂÂÂÂÂÂ if (IS_ERR(qcom_iommu->local_base))
> > +ÂÂÂÂÂÂÂÂÂÂÂ return PTR_ERR(qcom_iommu->local_base);
> > +ÂÂÂ }
>
> ...or just use devm_platform_ioremap_resource() to make the whole 
> thing simpler.
Yes, I was going to simplify the code here, but status check is still 
required.

So I'm waiting.

Thanks,

Tang Bin