Re: [PATCH 0/4] of: property: fw_devlink misc fixes

From: Nicolas Saenz Julienne
Date: Thu Apr 16 2020 - 07:06:59 EST


On Wed, 2020-04-15 at 11:17 -0700, Saravana Kannan wrote:
> On Wed, Apr 15, 2020 at 8:06 AM Nicolas Saenz Julienne
> <nsaenzjulienne@xxxxxxx> wrote:
> > As I'm interested in using this feature to fine-tune Raspberry Pi 4's
>
> You've made my day! Finally another user outside of Android. :) If
> this does improve the boot time, I'd be super interested to see the
> numbers.

Actually making the boot time faster isn't my main objective just a nice
possible side-effect. I'll give you some numbers nonetheless :).

I have two things in mind:
- Exploring if fw_devlink=on can help us solve a rather convoluted device
initialization depency we're seeing in RPi4. It could potentially prevent us
from adding nasty platform specific driver code.
- See if we can use all this information to fine-tune initrd generation on
smaller arm devices with limited i/o speeds.

Do you have any plans in moving the default behavior to fw_devlink=on? If so
what is blocking us?

Also do you think it'd be reasonable to add a DT binding to set the desired
fw_devlink level? Something like a 'linux,fw_devlink' property under the
/chosen node.

> > device probe dependencies, I tried to get the board to boot with
> > fw_devlink=on. As of today's linux-next the board won't boot with that
> > option. I tried to address the underlying issues.
>
> I'll review the patches. Apologies in advance if my explanations
> aren't thorough. A bit swamped right now.

They were pretty clear!

Thanks,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part