Re: [PATCH v3 11/13] dt-bindings: reset: imx8mp: Add ids for audiomix reset

[Arnd Bergmann]

On Wed, Apr 15, 2020 at 10:04 AM Abel Vesa <abel.vesa@xxxxxxx> wrote:
>
> Add all the reset ids for the audiomix reset.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> ---
>  include/dt-bindings/reset/imx-audiomix-reset.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 include/dt-bindings/reset/imx-audiomix-reset.h
>
> diff --git a/include/dt-bindings/reset/imx-audiomix-reset.h b/include/dt-bindings/reset/imx-audiomix-reset.h
> new file mode 100644
> index 00000000..67392c3
> --- /dev/null
> +++ b/include/dt-bindings/reset/imx-audiomix-reset.h
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright 2019 NXP.
> + */
> +
> +#ifndef DT_BINDING_RESET_IMX_AUDIOMIX_H
> +#define DT_BINDING_RESET_IMX_AUDIOMIX_H
> +
> +#define IMX_AUDIOMIX_EARC_RESET                0x0
> +#define IMX_AUDIOMIX_EARC_PHY_RESET    0x1
> +
> +#define IMX_AUDIOMIX_RESET_NUM         2
> +

This list doesn't seem necessary, as the number you pass ends up
simply being the bit index in a single register.

In a case like this you should better not have macros at all, those
are only needed when there is no easy way to the numbers in
the DT into something the driver can make sense of.

       Arnd