Re: [PATCH v5 0/3] perf synthetic events

From: Namhyung Kim
Date: Thu Apr 16 2020 - 10:33:25 EST


Hi Ian,

On Wed, Apr 15, 2020 at 2:40 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Add a multi-threaded version of the internals synthesize benchmark. It
> attempts to compute a time per event synthesized, but as it is reading
> /proc there are issues:
> - permissions if not run as root
> - "random" nature of /proc
>
> By default the benchmark is disabled but can be enabled with a
> flag. It has been useful in gauging the value of multi-threaded
> improvements not included here as their value appears minimal.
>
> The patch set includes 2 patches that improve synthesis performance
> and updates the benchmark numbers:
> https://lore.kernel.org/lkml/20200411064248.247530-1-irogers@xxxxxxxxxx/
>
> v4 added a missing test file
> v3 improved documenation, return values and added testing to the io framework
> following feedback from namhyung@xxxxxxxxxxx
> v2 addressed single threaded synthesize benchmark issues from jolsa@xxxxxxxxxx
> https://lore.kernel.org/lkml/20200402154357.107873-1-irogers@xxxxxxxxxx/
>
> Ian Rogers (3):
> perf bench: add a multi-threaded synthesize benchmark
> tools api: add a lightweight buffered reading api
> perf synthetic events: Remove use of sscanf from /proc reading

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks
Namhyung