Re: [PATCH 1/1] selftests: kvm: Add overlapped memory regions test

[Paolo Bonzini]

On 16/04/20 01:57, Krish Sadhukhan wrote:
> 
>> Add the test_overlap_memory_regions() test case in
>> set_memory_region_test. This should check that overlapping
>> memory regions on the guest physical address cannot be added.
> 
> 
> I think the commit header and the body need some improvement. For example,
> 
> ÂÂÂ ÂÂÂ Header: Test that overlapping guest memory regions can not be added
> 
> ÂÂÂ ÂÂÂ Body:Â Enhance the existing tests in set_memory_region_test.c so
> that it tests overlapping guest
> 
> ÂÂÂ ÂÂÂ ÂÂÂ ÂÂÂ ÂÂÂ memory regions. The new test verifies that adding
> overlapping guest memory regions fails.

I like Wainer's header and your body. :)

Paolo