RE: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume routines

[Harini Katakam]

Hi Nicolas,

> -----Original Message-----
> From: nicolas.ferre@xxxxxxxxxxxxx [mailto:nicolas.ferre@xxxxxxxxxxxxx]
> Sent: Thursday, April 16, 2020 11:14 PM
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Claudiu
> Beznea <claudiu.beznea@xxxxxxxxxxxxx>; Harini Katakam
> <harinik@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; David S. Miller <davem@xxxxxxxxxxxxx>;
> Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>; pthombar@xxxxxxxxxxx;
> sergio.prado@xxxxxxxxxxxxxx; antoine.tenart@xxxxxxxxxxx;
> f.fainelli@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; andrew@xxxxxxx; Michal Simek
> <michals@xxxxxxxxxx>; Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>; Rafal
> Ozieblo <rafalo@xxxxxxxxxxx>
> Subject: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume
> routines
> 
> From: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> 
> Use the proper struct device pointer to check if the wakeup flag and wakeup
> source are positioned.
> Use the one passed by function call which is equivalent to &bp->dev-
> >dev.parent.
> 
> It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan
> feature is used.

Sorry I have some mail issues; meant to reply earlier.
Tested patches 1, 2, 3 in this set and they work for me.

I'll try patch 4; it looks similar to what I'm using locally but I'll add whatever
tie-off queue handling is required on top of your series, thanks.

Regards,
Harini