Re: [PATCH] samples/hw_breakpoint: make sample_hbp static
From: Will Deacon
Date: Fri Apr 17 2020 - 03:32:02 EST
On Fri, Apr 17, 2020 at 03:35:42PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> samples/hw_breakpoint/data_breakpoint.c:24:19: warning: symbol
> 'sample_hbp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> ---
> samples/hw_breakpoint/data_breakpoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c
> index 418c46fe5ffc..37c4f0ea8e53 100644
> --- a/samples/hw_breakpoint/data_breakpoint.c
> +++ b/samples/hw_breakpoint/data_breakpoint.c
> @@ -21,7 +21,7 @@
> #include <linux/perf_event.h>
> #include <linux/hw_breakpoint.h>
>
> -struct perf_event * __percpu *sample_hbp;
> +static struct perf_event * __percpu *sample_hbp;
>
> static char ksym_name[KSYM_NAME_LEN] = "jiffies";
> module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);
Acked-by: Will Deacon <will@xxxxxxxxxx>
Will