Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

[Jason Yan]

å 2020/4/17 18:26, Sergei Shtylyov åé:
> Hello!
>
> On 17.04.2020 10:40, Jason Yan wrote:
>
> > Fix the following sparse warning:
> >
> > drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
> > 'bcm7038_l1_of_init' was not declared. Should it be static?
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > ---
> > Â drivers/irqchip/irq-bcm7038-l1.c | 2 +-
> > Â 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/irq-bcm7038-l1.c 
> > b/drivers/irqchip/irq-bcm7038-l1.c
> > index eb9bce93cd05..fd7c537fb42a 100644
> > --- a/drivers/irqchip/irq-bcm7038-l1.c
> > +++ b/drivers/irqchip/irq-bcm7038-l1.c
> > @@ -416,7 +416,7 @@ static const struct irq_domain_ops 
> > bcm7038_l1_domain_ops = {
> > ÂÂÂÂÂ .mapÂÂÂÂÂÂÂÂÂÂÂ = bcm7038_l1_map,
> > Â };
> > -int __init bcm7038_l1_of_init(struct device_node *dn,
> > +static int __init bcm7038_l1_of_init(struct device_node *dn,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ struct device_node *parent)
>
>  ÂÂ Reindent the above line please, it should start under *struct* on 
> the 1st line.

OK, will cook a new one.

> [...]
>
> MBR, Sergei
>
> .