Re: [PATCH v2] ASoC: bdw-rt5650: remove 3-channel capture support

From: Pierre-Louis Bossart
Date: Fri Apr 17 2020 - 09:33:43 EST




On 4/17/20 2:59 AM, Cezary Rojewski wrote:
On 2020-04-17 03:32, Lu, Brent wrote:

It seems like a generic problem on all Broadwell devices so let's solve with
one a single patchset.

Shouldn't we just add the 2ch constraints for broadwell.c and bdw-rt5677.c,
and the 2 or 4ch constraint for bdw-rt5650.c? Would this work for you?

Thanks
-Pierre

Hi Pierre,

Are you saying submitting a new patch to add constraints to all three broadwell.c,
bdw-rt5650.c, and bdw-rt5677.c?


Regards,
Brent


What Pierre suggested is that you submit a series of patches instead - one for each of BDW machine boards. If the same problem exists on all of them, there is no reason to left other boards unattended.

Yes, a series of 3 patches with the same code pattern, the only variation being 4 ch allowed for bdw-rt5650.c in addition to the default 2ch for all 3 boards.

Thanks
-Pierre