Re: [PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'
From: Daniel Vetter
Date: Fri Apr 17 2020 - 11:24:20 EST
On Fri, Apr 17, 2020 at 06:10:32PM +0800, YueHaibing wrote:
> drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: âhdmi_idsâ defined but not used [-Wunused-const-variable=]
> static const struct pci_device_id hdmi_ids[] = {
> ^~~~~~~~
>
> It is never used, remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
Queued for 5.8, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> index b25086f252ae..a097a59a9eae 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> @@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
> kfree(gma_encoder);
> }
>
> -static const struct pci_device_id hdmi_ids[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
> - { 0 }
> -};
> -
> void oaktrail_hdmi_setup(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv = dev->dev_private;
> --
> 2.17.1
>
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch