Re: [PATCH] ASoC: Intel: atom: remove unused 'sst_mix_voip_controls'

From: Pierre-Louis Bossart
Date: Fri Apr 17 2020 - 11:48:25 EST




On 4/17/20 4:23 AM, Jason Yan wrote:
Fix the following gcc warning:

sound/soc/intel/atom/sst-atom-controls.c:710:30: warning:
âsst_mix_voip_controlsâ defined but not used [-Wunused-const-variable=]
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);

I'd prefer it if we didn't change this but only added __maybe_unused in the macro.

This is 2013/2014 legacy stuff, some parts were not upstreamed and this was used by out-of-tree Android variations, and I don't know the consequences of taking this out.

Better just squelch the warning but not change anything, no?

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
---
sound/soc/intel/atom/sst-atom-controls.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
index 69f3af4524ab..541f0059ba7a 100644
--- a/sound/soc/intel/atom/sst-atom-controls.c
+++ b/sound/soc/intel/atom/sst-atom-controls.c
@@ -707,7 +707,6 @@ SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_pcm2_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_sprot_l0_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l1_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l2_controls);
-SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec0_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec1_controls);
SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_modem_controls);