Re: [v2 5/7] remoteproc: Restructure firmware name allocation

From: Suman Anna
Date: Fri Apr 17 2020 - 12:15:59 EST


On 4/17/20 10:48 AM, Markus Elfring wrote:
ÂÂÂÂp = firmware ? kstrdup_const(â) : kasprintf(â);

For simple assignments, I too prefer the ternary operator,

Thanks for your feedback.


but in this case, I think it is better to leave the current code as is.

Would you like to consider the use of the function âkvasprintf_constâ
according to your review comment for the update step â[PATCH v2 4/7] remoteproc:
Use kstrdup_const() rather than kstrup()â?

This patch is just swapping the condition order, so will automatically be adjusted for any changes in patch 4 during the rebase.

regards
Suman