Re: regression 5.6.4->5.6.5 at drivers/acpi/ec.c
From: Toralf FÃrster
Date: Fri Apr 17 2020 - 12:36:37 EST
On 4/17/20 5:53 PM, Rafael J. Wysocki wrote:
> Does the patch below (untested) make any difference?
>
> ---
> drivers/acpi/ec.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: linux-pm/drivers/acpi/ec.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/ec.c
> +++ linux-pm/drivers/acpi/ec.c
> @@ -2067,7 +2067,10 @@ static struct acpi_driver acpi_ec_driver
> .add = acpi_ec_add,
> .remove = acpi_ec_remove,
> },
> - .drv.pm = &acpi_ec_pm,
> + .drv = {
> + .probe_type = PROBE_FORCE_SYNCHRONOUS,
> + .pm = &acpi_ec_pm,
> + },
> };
>
> static void acpi_ec_destroy_workqueues(void)
I'd say no, but for completeness:
pci 0000:03:00.0: reg 0x10: [mem 0xe0400000-0xe0401fff 64bit]
pci 0000:03:00.0: PME# supported from D0 D3hot D3cold
pci 0000:00:1c.1: PCI bridge to [bus 03]
pci 0000:00:1c.1: bridge window [mem 0xe0400000-0xe04fffff]
ACPI: EC: interrupt unblocked
ACPI: EC: event unblocked
ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62
ACPI: EC: GPE=0x25
ACPI: \_SB_.PCI0.LPC_.EC__: Boot ECDT EC initialization complete
ACPI: \_SB_.PCI0.LPC_.EC__: EC: Used to handle transactions and events
ACPI: EC: EC_CMD/EC_SC=0x66, EC_DATA=0x62
ACPI: EC: GPE=0x25
ACPI: \_SB_.PCI0.LPC_.EC__: Boot ECDT EC initialization complete
ACPI: \_SB_.PCI0.LPC_.EC__: EC: Used to handle transactions and events
------------[ cut here ]------------
Could not request EC data io port 0x62
WARNING: CPU: 2 PID: 1 at drivers/acpi/ec.c:1677 acpi_ec_add+0x26e/0x280
Modules linked in:
CPU: 2 PID: 1 Comm: swapper/0 Tainted: G T 5.6.5 #6
Hardware name: LENOVO 20AQCTO1WW/20AQCTO1WW, BIOS GJET92WW (2.42 ) 03/03/2017
RIP: 0010:acpi_ec_add+0x26e/0x280
Code: fe ff ff 48 8b 75 10 48 c7 c7 d0 27 7b b2 e8 81 c7 b6 ff 0f 0b e9 c9 fe ff ff 48 8b 75 18 48 c7 c7 a8 27 7b b2 e8 6a c7 b6 ff <0f> 0b e9 8a fe ff ff 41 bc f4 ff ff ff e9 ac fe ff ff 48 83 3d f8
RSP: 0000:ffffa7e980053c80 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffa359700b3800 RCX: 0000000000000000
RDX: 0000000000000026 RSI: ffffffffb306f666 RDI: ffffffffb306fa66
RBP: ffffa35970ab6300 R08: 00000000894e0463 R09: 0000000000000026
R10: 000000000000000f R11: ffffa7e980053aa8 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000030
FS: 0000000000000000(0000) GS:ffffa35972700000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 00000001a480a001 CR4: 00000000001606e0
Call Trace:
acpi_device_probe+0x40/0x100
really_probe+0xe8/0x2d0
driver_probe_device+0x57/0xd0
? driver_allows_async_probing+0x50/0x50
bus_for_each_drv+0x90/0xe0
__device_attach+0xea/0x160
acpi_bus_register_early_device+0x4b/0x70
acpi_ec_init+0x2ee/0x361
acpi_init+0x410/0x4a0
? acpi_sleep_proc_init+0x4c/0x4c
do_one_initcall+0x93/0x1f0
kernel_init_freeable+0x3e7/0x4cc
? rest_init+0xc0/0xc0
kernel_init+0x6/0x110
? rest_init+0xc0/0xc0
ret_from_fork+0x35/0x40
---[ end trace a946e45fe1b78ebc ]---
------------[ cut here ]------------
Could not request EC cmd io port 0x66
WARNING: CPU: 2 PID: 1 at drivers/acpi/ec.c:1679 acpi_ec_add+0x257/0x280
Modules linked in:
CPU: 2 PID: 1 Comm: swapper/0 Tainted: G W T 5.6.5 #6
Hardware name: LENOVO 20AQCTO1WW/20AQCTO1WW, BIOS GJET92WW (2.42 ) 03/03/2017
RIP: 0010:acpi_ec_add+0x257/0x280
Code: 8b 55 00 48 89 ef 48 89 10 e8 65 e0 ff ff 48 8b 2d 4e d7 3b 01 e9 4a fe ff ff 48 8b 75 10 48 c7 c7 d0 27 7b b2 e8 81 c7 b6 ff <0f> 0b e9 c9 fe ff ff 48 8b 75 18 48 c7 c7 a8 27 7b b2 e8 6a c7 b6
RSP: 0000:ffffa7e980053c80 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffa359700b3800 RCX: 0000000000000000
RDX: 0000000000000025 RSI: ffffffffb306f665 RDI: ffffffffb306fa65
RBP: ffffa35970ab6300 R08: 000000008997875e R09: 0000000000000025
R10: 000000000000000f R11: ffffa7e980053aa8 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000030
FS: 0000000000000000(0000) GS:ffffa35972700000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 00000001a480a001 CR4: 00000000001606e0
Call Trace:
acpi_device_probe+0x40/0x100
really_probe+0xe8/0x2d0
driver_probe_device+0x57/0xd0
? driver_allows_async_probing+0x50/0x50
bus_for_each_drv+0x90/0xe0
__device_attach+0xea/0x160
acpi_bus_register_early_device+0x4b/0x70
acpi_ec_init+0x2ee/0x361
acpi_init+0x410/0x4a0
? acpi_sleep_proc_init+0x4c/0x4c
do_one_initcall+0x93/0x1f0
kernel_init_freeable+0x3e7/0x4cc
? rest_init+0xc0/0xc0
kernel_init+0x6/0x110
? rest_init+0xc0/0xc0
ret_from_fork+0x35/0x40
---[ end trace a946e45fe1b78ebd ]---
iommu: Default domain type: Translated
pci 0000:00:02.0: vgaarb: setting as boot VGA device
pci 0000:00:02.0: vgaarb: VGA device added: decodes=io+mem,owns=io+mem,locks=none
pci 0000:00:02.0: vgaarb: bridge control possible
vgaarb: loaded
SCSI subsystem initialized
libata version 3.00 loaded.
ACPI: bus type USB registered
usbcore: registered new interface driver usbfs
usbcore: registered new interface driver hub
usbcore: registered new device driver usb
pps_core: LinuxPPS API ver. 1 registered
--
Toralf