Re: [PATCH] perf/core: fix parent pid/tid in task exit events

From: Ian Rogers
Date: Fri Apr 17 2020 - 17:31:19 EST


On Fri, Apr 17, 2020 at 11:45 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Fri, Apr 17, 2020 at 11:28:42AM -0700, Ian Rogers wrote:
> > Current logic yields the child task as the parent.
> >
> > Before:
> > $ perf record bash -c "perf list > /dev/null"
> > $ perf script -D |grep 'FORK\|EXIT'
> > 4387036190981094 0x5a70 [0x30]: PERF_RECORD_FORK(10472:10472):(10470:10470)
> > 4387036606207580 0xf050 [0x30]: PERF_RECORD_EXIT(10472:10472):(10472:10472)
> > 4387036607103839 0x17150 [0x30]: PERF_RECORD_EXIT(10470:10470):(10470:10470)
> > ^
> > Note the repeated values here -------------------/
> >
> > After:
> > 383281514043 0x9d8 [0x30]: PERF_RECORD_FORK(2268:2268):(2266:2266)
> > 383442003996 0x2180 [0x30]: PERF_RECORD_EXIT(2268:2268):(2266:2266)
> > 383451297778 0xb70 [0x30]: PERF_RECORD_EXIT(2266:2266):(2265:2265)
> >
>
> Fixes: .... ?

Fixes: 94d5d1b2d891 ("perf_counter: Report the cloning task as parent
on perf_counter_fork()")

Sorry, re-sending as plain-text was disabled on the message and so it
bounced on lkml. Took some digging to find the original commit :-)

Thanks,
Ian

>
> > Reported-by: KP Singh <kpsingh@xxxxxxxxxx>
> > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>