Re: [PATCH net-next] dt-bindings: net: mdio: Document common properties

From: Andrew Lunn
Date: Sat Apr 18 2020 - 10:35:22 EST


On Fri, Apr 17, 2020 at 05:51:26PM -0700, Florian Fainelli wrote:
> Some of the properties pertaining to the broken turn around or resets
> were only documented in ethernet-phy.yaml while they are applicable
> across all MDIO devices and not Ethernet PHYs specifically which are a
> superset.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
> .../devicetree/bindings/net/mdio.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
> index 50c3397a82bc..58d486db5651 100644
> --- a/Documentation/devicetree/bindings/net/mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/mdio.yaml
> @@ -50,6 +50,33 @@ patternProperties:
> description:
> The ID number for the PHY.
>
> + broken-turn-around:
> + $ref: /schemas/types.yaml#definitions/flag
> + description:
> + If set, indicates the PHY device does not correctly release
> + the turn around line low at the end of a MDIO transaction.

Hi Florian

Since this is a generic property, maybe this should be "the MDIO
device"? Probably the whole document needs s/PHY/MDIO/g ?

Andrew