RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI

[Avri Altman]

> > -----Original Message-----
> > From: Avri Altman <Avri.Altman@xxxxxxx>
> > Sent: 18 April 2020 18:09
> > To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; robh@xxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
> krzk@xxxxxxxxxx;
> > martin.petersen@xxxxxxxxxx; kwmad.kim@xxxxxxxxxxx;
> > stanley.chu@xxxxxxxxxxxx; cang@xxxxxxxxxxxxxx; linux-samsung-
> > soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Subject: RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI
> >
> >
> > >
> > > This patch-set introduces UFS (Universal Flash Storage) host
> > > controller support for Samsung family SoC. Mostly, it consists of UFS
> > > PHY and host specific driver.
> > >
> > > - Changes since v5:
> > > * re-introduce various quicks which was removed because of no driver
> > > * consumer of those quirks, initial 4 patches does the same.
> > You forgot to add those quirks to ufs_fixups.
> 
> ufs_fixups are for ufs __device__ related quirks, what I have posted are all
> host controller quirks.
Right.
So what I am saying is that I am missing the hba->quirks |= UFSHCI_QUIRK_<new-quirk>
In ufs-exynos.c for each one of the new quirks.