Re: [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro
From: Jonathan Cameron
Date: Sat Apr 18 2020 - 12:14:18 EST
On Wed, 15 Apr 2020 11:41:24 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@xxxxxxxxxx> wrote:
> On Wed, 2020-04-15 at 12:10 +0200, Lars Engebretsen wrote:
> > This change removes the semi-colon from the devm_iio_device_register()
> > macro which seems to have been added by accident via commit 63b19547cc3d9
> > ("iio: Use macro magic to avoid manual assign of driver_module").
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
The above reference to where the bug was introduced should have been
a Fixes: tag as that guides where this is backported to.
I made it so whilst applying.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > Signed-off-by: Lars Engebretsen <lars@xxxxxxxxxxxxxx>
> > ---
> > Changelog v1 -> v2:
> > * added commit change description
> >
> > include/linux/iio/iio.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index d63884a54939..76ba7c9fd3e0 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
> > * 0 on success, negative error number on failure.
> > */
> > #define devm_iio_device_register(dev, indio_dev) \
> > - __devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> > + __devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
> > int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
> > struct module *this_mod);
> > int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);