Re: [PATCH 4/4] test_kmod: Avoid potential double free in trigger_config_run_type()

From: Markus Elfring
Date: Sat Apr 18 2020 - 13:23:32 EST


> It should set config->test_fs instead of config->test_driver as NULL
> after kfree_const(config->test_fs) to avoid potential double free.

I suggest to improve this change description.

* How do you think about a wording variant like the following?

Reset the member âtest_fsâ of the test configuration after a call
of the function âkfree_constâ to a null pointer so that a double
memory release will not be performed.

* Would you like to add the tag âFixesâ?

Regards,
Markus