[PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c
From: Randy Dunlap
Date: Sat Apr 18 2020 - 14:42:14 EST
Fix gcc empty-body warning when -Wextra is used:
../drivers/base/devcoredump.c:297:42: warning: suggest braces around empty body in an âifâ statement [-Wempty-body]
../drivers/base/devcoredump.c:301:42: warning: suggest braces around empty body in an âifâ statement [-Wempty-body]
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/base/devcoredump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20200417.orig/drivers/base/devcoredump.c
+++ linux-next-20200417/drivers/base/devcoredump.c
@@ -9,6 +9,7 @@
*
* Author: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
*/
+#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/device.h>
#include <linux/devcoredump.h>
@@ -294,11 +295,11 @@ void dev_coredumpm(struct device *dev, s
if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
"failing_device"))
- /* nothing - symlink will be missing */;
+ do_empty(); /* nothing - symlink will be missing */
if (sysfs_create_link(&dev->kobj, &devcd->devcd_dev.kobj,
"devcoredump"))
- /* nothing - symlink will be missing */;
+ do_empty(); /* nothing - symlink will be missing */
INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
schedule_delayed_work(&devcd->del_wk, DEVCD_TIMEOUT);