Re: [PATCH net-next 01/10] net: hns3: split out hclge_fd_check_ether_tuple()

[David Miller]

From: Huazhong Tan <tanhuazhong@xxxxxxxxxx>
Date: Sat, 18 Apr 2020 14:47:00 +0800

> +static int hclge_fd_check_spec(struct hclge_dev *hdev,
> +			       struct ethtool_rx_flow_spec *fs,
> +			       u32 *unused_tuple)
> +{
> +	int ret = 0;

There is no code path that uses 'ret' without it first being
assigned.  If I let this code in, then someone is going to
submit a fixup patch removing the initialization.