Re: [PATCH 2/8] signal: clean up __copy_siginfo_to_user32
From: Christoph Hellwig
Date: Sun Apr 19 2020 - 04:03:44 EST
On Fri, Apr 17, 2020 at 04:08:23PM -0500, Eric W. Biederman wrote:
> This bothers me because it makes all architectures pay for the sins of
> x32. Further it starts burying the details of the what is happening in
> architecture specific helpers. Hiding the fact that there is only
> one niche architecture that does anything weird.
>
> I am very sensitive to hiding away signal handling details right now
> because way to much of the signal handling code got hidden in
> architecture specific files and was quite buggy because as a result.
I much prefer the unconditional flags over the crazy ifdef mess in
the current coe and your version. Except for that and the rather
strange and confusing copy_siginfo_to_external32 name it pretty much
looks the same.