Re: [PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()
From: Markus Elfring
Date: Sun Apr 19 2020 - 04:15:50 EST
> kvfree ensure that the null pointer will do nothing.
I suggest to improve the commit message.
Would you like to adjust the patch subject?
Are you looking for further questionable condition checks?
â
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
â
> + kvfree(info);
>
> return r;
> }
How do you think about to omit a blank line behind the function call
at this source code place?
Regards,
Markus