Re: [PATCH v2] iommu/qcom: Fix local_base status check

[Markus Elfring]

> â
>> +++ b/drivers/iommu/qcom_iommu.c
>> @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
>>  	qcom_iommu->dev = dev;
>>
>>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
â
>>  		qcom_iommu->local_base = devm_ioremap_resource(dev, res);
â
> Please take another look at a corresponding usage example.

I would like to point another possibility out for desirable software evolution.
How do you think about to call a âknownâ wrapper function instead?

devm_platform_get_and_ioremap_resource
https://elixir.bootlin.com/linux/v5.7-rc1/source/drivers/base/platform.c#L66
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/base/platform.c

Regards,
Markus