RE: [PATCH] drivers/char/hw_random/cctrng.c: Compilation fix.

[Hadar Gat]

> From: Jagadeesh Pagadala <jagdsh.linux@xxxxxxxxx>
> 
> Adding the needed header <linux/fips.h> to fix following compilation error.
> 
> 	CC      drivers/char/hw_random/cctrng.o
> 	drivers/char/hw_random/cctrng.c: In function
> âcc_trng_compwork_handlerâ:
> 	drivers/char/hw_random/cctrng.c:334:49: error: âfips_enabledâ
> undeclared (first use in this function)
> 	  if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
> 							 ^
> 	drivers/char/hw_random/cctrng.c:334:49: note: each undeclared
> identifier is reported only once for each function it appears in
> 	drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of
> function âfips_fail_notifyâ [-Werror=implicit-function-declaration]
> 	   fips_fail_notify();
> 	   ^
> 	cc1: some warnings being treated as errors
> 	make[4]: *** [drivers/char/hw_random/cctrng.o] Error 1
> 
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@xxxxxxxxx>
> ---
>  drivers/char/hw_random/cctrng.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/char/hw_random/cctrng.c
> b/drivers/char/hw_random/cctrng.c index bdcd562..3124269 100644
> --- a/drivers/char/hw_random/cctrng.c
> +++ b/drivers/char/hw_random/cctrng.c
> @@ -18,6 +18,10 @@
> 
>  #include "cctrng.h"
> 
> +#ifdef CONFIG_CRYPTO_FIPS
> +#include <linux/fips.h>
> +#endif
> +
>  #define CC_REG_LOW(name)  (name ## _BIT_SHIFT)  #define
> CC_REG_HIGH(name) (CC_REG_LOW(name) + name ## _BIT_SIZE - 1)
> #define CC_GENMASK(name)  GENMASK(CC_REG_HIGH(name),
> CC_REG_LOW(name))
> --
> 1.8.3.1

Hi Jagadeesh,
Thanks for your fix but this compilation issue is already fixed.
It was pushed few days ago and is waiting to be applied.
BR,
Hadar