Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet

From: Dmitry Torokhov
Date: Sun Apr 19 2020 - 14:01:41 EST


On Sun, Apr 19, 2020 at 09:46:23AM +0200, LuK1337 wrote:
> From: Åukasz Patron <priv.luk@xxxxxxxxx>
>
> Appending { 0x05, 0x20, 0x02, 0x0f, 0x06 } to
> xboxone_fw2015_init fixes an issue where the
> controller is somewhat stuck in bluetooth
> mode until you plug it into Windows PC.
>
> Signed-off-by: Åukasz Patron <priv.luk@xxxxxxxxx>

Thank you Åukasz. Could you please tell me what device(s) have you
observed the issue with? I am a bit worried if this may interfere with
other devices that currently work fine with the driver. Cameron, Mark,
do you have any concerns here?

> ---
> drivers/input/joystick/xpad.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6b40a1c68f9f..894fa81f717a 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -455,7 +455,8 @@ struct xboxone_init_packet {
> * or later firmware installed (or present from the factory).
> */
> static const u8 xboxone_fw2015_init[] = {
> - 0x05, 0x20, 0x00, 0x01, 0x00
> + 0x05, 0x20, 0x00, 0x01, 0x00,
> + 0x05, 0x20, 0x02, 0x0f, 0x06
> };
>
> /*
> --
> 2.26.0
>

Thanks.

--
Dmitry