Re: [PATCH] sh: fix build error in mm/init.c

From: Masahiro Yamada
Date: Sun Apr 19 2020 - 16:47:53 EST


Hi Linus,

On Mon, Apr 13, 2020 at 10:48 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> The closing parenthesis is missing.
>
> Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>



Will you pick up this directly ?
The SuperH subsystem is inactive these days.

https://lore.kernel.org/patchwork/patch/1223032/


This is easy to review, and ARCH=sh build is apparently broken.

Thanks.





> ---
>
> arch/sh/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
> index b9de2d4fa57e..8d2a68aea1fc 100644
> --- a/arch/sh/mm/init.c
> +++ b/arch/sh/mm/init.c
> @@ -412,7 +412,7 @@ int arch_add_memory(int nid, u64 start, u64 size,
> unsigned long nr_pages = size >> PAGE_SHIFT;
> int ret;
>
> - if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot)
> + if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot))
> return -EINVAL;
>
> /* We only have ZONE_NORMAL, so this is easy.. */
> --
> 2.25.1
>


--
Best Regards
Masahiro Yamada