Re: [PATCH v12 5/6] rtc: mt6397: Add support for the MediaTek MT6358 RTC

[Lee Jones]

On Fri, 17 Apr 2020, Ran Bi wrote:

> On Fri, 2020-04-17 at 16:29 +0800, Ran Bi wrote:
> > On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote:
> > > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:
> > > 
> > > > From: Ran Bi <ran.bi@xxxxxxxxxxxx>
> > > > 
> > > > This add support for the MediaTek MT6358 RTC. Driver using
> > > > compatible data to store different RTC_WRTGR address offset.
> > > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff
> > > > driver which only needed by armv7 CPU without ATF.
> > > > 
> > > > Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> > > > Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>
> > > > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> > > > Acked-by: Sebastian Reichel <sre@xxxxxxxxxx>
> > > > Signed-off-by: Ran Bi <ran.bi@xxxxxxxxxxxx>
> > > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
> > > 
> > > Please place these in chronological order.  They should provide some
> > > history, rather than a unordered slab list of random sign-offs.
> > > 
> > 
> > I suppose that you mean the order should be like below, right?
> > Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>
> > Acked-by: Sebastian Reichel <sre@xxxxxxxxxx>
> > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> > Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
> > Signed-off-by: Ran Bi <ran.bi@xxxxxxxxxxxx>
> > 
> 
> Correction, I think following is the correct chronological order:
> Signed-off-by: Ran Bi <ran.bi@xxxxxxxxxxxx>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
> Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Acked-by: Sebastian Reichel <sre@xxxxxxxxxx>
> Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>

This looks better, yes.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog