Re: [tip: ras/core] x86/mce: Add a struct mce.kflags field
From: Christoph Hellwig
Date: Mon Apr 20 2020 - 04:06:42 EST
On Wed, Apr 15, 2020 at 09:49:48AM -0000, tip-bot2 for Tony Luck wrote:
> The following commit has been merged into the ras/core branch of tip:
>
> Commit-ID: 1de08dccd383482a3e88845d3554094d338f5ff9
> Gitweb: https://git.kernel.org/tip/1de08dccd383482a3e88845d3554094d338f5ff9
> Author: Tony Luck <tony.luck@xxxxxxxxx>
> AuthorDate: Fri, 14 Feb 2020 14:27:16 -08:00
> Committer: Borislav Petkov <bp@xxxxxxx>
> CommitterDate: Tue, 14 Apr 2020 15:58:43 +02:00
>
> x86/mce: Add a struct mce.kflags field
>
> There can be many different subsystems register on the mce handler
> chain. Add a new bitmask field and define values so that handlers can
> indicate whether they took any action to log or otherwise handle an
> error.
>
> The default handler at the end of the chain can use this information to
> decide whether to print to the console log.
>
> Boris suggested a generic name and leaving plenty of spare bits for
> possible future use.
>
> [ bp: Move flag bits to the internal mce.h header and use BIT_ULL(). ]
Err, how can you add a new field to an uapi structure and not break
things?