Re: [PATCH] staging: qlge: replace deprecated apis pci_dma_*

[Christoph Hellwig]

On Sun, Apr 19, 2020 at 10:08:16AM +0900, Sidong Yang wrote:
>  	direction =
> -	    (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? PCI_DMA_TODEVICE :
> -	    PCI_DMA_FROMDEVICE;
> +	    (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? DMA_TO_DEVICE :
> +	    DMA_FROM_DEVICE;

Can you unobsfucate this while you are at it?

	if (bit & (CFG_LRQ | CFG_LR | CFG_LCQ))
		direction = DMA_TO_DEVICE;
	else
		direction = DMA_FROM_DEVICE;

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>