Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

[Ramuthevar, Vadivel MuruganX]

 On 20/4/2020 3:40 pm, Boris Brezillon wrote:

> On Mon, 20 Apr 2020 12:18:34 +0800
> "Ramuthevar, Vadivel MuruganX"
> <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx> wrote:
>
>
> > > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> > > > index a80a46bb5b8b..9efc4bbaf4a3 100644
> > > > --- a/drivers/mtd/nand/raw/Kconfig
> > > > +++ b/drivers/mtd/nand/raw/Kconfig
> > > > @@ -457,6 +457,13 @@ config MTD_NAND_CADENCE
> > > >    	  Enable the driver for NAND flash on platforms using a Cadence NAND
> > > >    	  controller.
> > > >    
> > > > +config MTD_NAND_INTEL_LGM
> > > > +	tristate "Support for NAND controller on Intel LGM SoC"
> > > > +	depends on X86
> > > Do we have a hard dependency on x86 here? Maybe 'depends on HAS_MMIO'
> > > would be enough.
> > yes Boris, we have hard dependency on x86.
> Given that the driver will also be used on a MIPS platform I would say
> no :P. Just to be clear, I was suggesting to replace the soon to emerge
>
> 	depends on X86 || MIPS || COMPILE_TEST
> 	depends HAS_IOMEM
>
> rule by
>
> 	depends on OF || COMPILE_TEST
> 	depends HAS_IOMEM

Thank you for the suggestion !

Yes, you are right since MIPS based SoCs also using the same driver, so 
we can add the above rule.

Regards
Vadivel