Re: [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support

[Tudor.Ambarus]

Hi, Mason,

On Monday, April 6, 2020 12:00:11 PM EEST Mason Yang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> mx25u51245g is a mass production for new design and
> replace mx66u51235f(phase out).
> 
> Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx>
> ---
>  drivers/mtd/spi-nor/macronix.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index c864ac8..e685aec 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -73,6 +73,9 @@
>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
>                               SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>                               SPI_NOR_4B_OPCODES) },
> +       { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024,

Shouldn't the ID be 0xc2953a?

We usually don't add new flashes if they are not tested. Please specify in the 
commit message with which controller you tested the flash. Please do the same 
for the previous patch.

The minimal test is a read, erase, read back, write and read back. This 
sequence should verify if read, erase and pp work fine.

Cheers,
ta