Re: [PATCH] Revert "mtd: spi-nor: Add 4B_OPCODES flag to w25q256"
From: Tudor.Ambarus
Date: Mon Apr 20 2020 - 06:53:37 EST
Hi, Robert, Chuanhong,
On Monday, April 6, 2020 3:23:44 PM EEST Robert Marko wrote:
> > > I don't have a w25q256jv available and can't compare SFDP table
> > > to create a fix similar to mx25l25635 one.
> >
> > I just tried and unable to dump SFDP on my W25Q256FV,
> > probably because my chip is too old to have one.
> > Could you check if your W25Q256JV has this and dump it?
> > Just add some prints in spi_nor_read_sfdp.
> > If a 4-byte address instruction table is present, current kernel
> > should be able to discover 4B_OPCODES support automatically.
> > Even if that's not the case we may still be able to distinguish
> > W25Q256FV and W25Q256JV using SFDP table.
>
> It appears that W25Q256JV has an SFDP table and in it advertises 3B or 4B
> modes.
Mantas tried a fix for this, see it at:
https://patchwork.ozlabs.org/project/linux-mtd/patch/1586958510-24012-1-git-send-email-mantas@xxxxxxxxxxxx/
Would you please check the thread?
Cheers,
ta