Re: [PATCH] PCI: pciehp: Cleanup unused HP_SUPR_RM macro

[Ani Sinha]

On Mon, Apr 20, 2020 at 2:39 PM Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
>
> On Sun, Apr 19, 2020 at 07:06:20PM +0530, Ani Sinha wrote:
> > We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore.
> > Consequently HP_SUPR_RM() macro is not used in the kernel source anymore.
> > Let's clean it up.
> >
> > Signed-off-by: Ani Sinha <ani@xxxxxxxxxxx>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> BTW, there seem to be other macros like EMI() that is not used anymore
> so maybe worth removing them as well.

Sent a patch.

>
>
> > ---
> >  drivers/pci/hotplug/pciehp.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> > index ae44f46..5747967 100644
> > --- a/drivers/pci/hotplug/pciehp.h
> > +++ b/drivers/pci/hotplug/pciehp.h
> > @@ -148,7 +148,6 @@ struct controller {
> >  #define MRL_SENS(ctrl)               ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
> >  #define ATTN_LED(ctrl)               ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
> >  #define PWR_LED(ctrl)                ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> > -#define HP_SUPR_RM(ctrl)     ((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS)
> >  #define EMI(ctrl)            ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
> >  #define NO_CMD_CMPL(ctrl)    ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
> >  #define PSN(ctrl)            (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
> > --
> > 2.7.4