Re: [PATCH v2 1/2] regmap: Simplify implementation of the regmap_read_poll_timeout() macro
From: Markus Elfring
Date: Mon Apr 20 2020 - 10:35:52 EST
â
> +++ b/include/linux/regmap.h
â
> @@ -122,26 +123,10 @@ struct reg_sequence {
> */
> #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us, timeout_us) \
> ({ \
â
> + int __ret, __tmp; \
> + __tmp = read_poll_timeout(regmap_read, __ret, __ret || (cond), \
> + sleep_us, timeout_us, false, (map), (addr), &(val)); \
> + __ret ?: __tmp; \
> })
* Would you like to delete double underscores from these variable names?
* I find another implementation detail suspicious.
Should the parameters âsleep_usâ and âtimeout_usâ be enclosed by
additional parentheses (similar to four other macro arguments)?
* Can the tag âFixesâ be relevant also for such adjustments?
Regards,
Markus