Re: [PATCH v5 12/12] arm64: dts: ls1028a-rdb: Add a spidev node for the mikroBUS

From: Vladimir Oltean
Date: Mon Apr 20 2020 - 11:10:50 EST


On Mon, 20 Apr 2020 at 17:38, Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
>
> On Wed, Mar 18, 2020 at 02:16:03AM +0200, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> >
> > For debugging, it is useful to have access to the DSPI controller
> > signals. On the reference design board, these are exported to either the
> > mikroBUS1 or mikroBUS2 connector (according to the CPLD register
> > BRDCFG3[SPI3]).
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> > ---
> > Changes in v5:
> > None.
> >
> > Changes in v4:
> > None.
> >
> > Changes in v3:
> > None.
> >
> > Changes in v2:
> > Change compatible string for spidev node.
> >
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > index 6d05b76c2c7a..0d27b5667b8c 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> > @@ -83,6 +83,20 @@
> > };
> > };
> >
> > +&dspi2 {
> > + bus-num = <2>;
> > + status = "okay";
> > +
> > + /* mikroBUS1 */
> > + spidev@0 {
> > + compatible = "rohm,dh2228fv";
>
> Is the compatible documented?
>
> Shawn
>
> > + spi-max-frequency = <20000000>;
> > + fsl,spi-cs-sck-delay = <100>;
> > + fsl,spi-sck-cs-delay = <100>;
> > + reg = <0>;
> > + };
> > +};
> > +
> > &esdhc {
> > sd-uhs-sdr104;
> > sd-uhs-sdr50;
> > --
> > 2.17.1
> >

I don't really know what's the status with spidev compatibles. I do
see other device trees are using this one, I thought it should be
fine.

Thanks,
-Vladimir