Re: [PATCH 2/2][next] m68k: amiga: config: Mark expected switch fall-through
From: Gustavo A. R. Silva
Date: Mon Apr 20 2020 - 12:05:33 EST
On 4/20/20 02:17, Geert Uytterhoeven wrote:
> On Fri, Mar 27, 2020 at 12:25 AM Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>> Mark switch cases where we are expecting to fall through.
>>
>> This patch fixes the following warning (Building: allmodconfig m68k):
>>
>> arch/m68k/amiga/config.c: In function âamiga_identifyâ:
>> ./arch/m68k/include/asm/amigahw.h:42:50: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> #define AMIGAHW_SET(name) (amiga_hw_present.name = 1)
>> ~~~~~~~~~~~~~~~~~~~~~~~^~~~
>> arch/m68k/amiga/config.c:223:3: note: in expansion of macro âAMIGAHW_SETâ
>> AMIGAHW_SET(PCMCIA);
>> ^~~~~~~~~~~
>> arch/m68k/amiga/config.c:224:2: note: here
>> case AMI_500:
>> ^~~~
>>
>> Replace the existing /* fall through */ comments and fix the issue above
>> by using the new pseudo-keyword fallthrough;
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> i.e. will queue in the m68k for-v5.8 branch.
>
Geert,
I wonder if you received the first patch of the series.
It seems lkml has been eating some messages, recently.
Thanks
--
Gustavo